Feature Flag backend completion #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcb37
reviewed
May 24, 2024
backend/packages/Upgrade/src/api/controllers/FeatureFlagController.ts
Outdated
Show resolved
Hide resolved
bcb37
reviewed
May 24, 2024
backend/packages/Upgrade/src/api/controllers/FeatureFlagController.ts
Outdated
Show resolved
Hide resolved
bcb37
reviewed
May 24, 2024
backend/packages/Upgrade/src/api/repositories/FeatureFlagRepository.ts
Outdated
Show resolved
Hide resolved
bcb37
previously requested changes
May 24, 2024
|
Thanks @bcb37, I have missed that part of 'disabled' and 'archived'. |
VivekFitkariwala
requested changes
May 27, 2024
backend/packages/Upgrade/src/api/controllers/validators/FeatureFlagValidator.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/controllers/FeatureFlagController.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/controllers/FeatureFlagController.ts
Outdated
Show resolved
Hide resolved
bcb37
reviewed
Jun 3, 2024
There was a problem hiding this comment.
@VivekFitkariwala @RidhamShah Do you think we need test cases in ExperimentAssignmentService.test.ts that verify that the inclusionExclusionLogic() method does what it's supposed to do?
|
@bcb37 We should have test cases which should cover inclusion and exclusion test cases. @RidhamShah can you add test cases related to Feature flag inclusion and exclusion? |
|
@bcb37 @danoswaltCL I have added integration test cases for checking include/exclude logic. We are now review and merge this branch. |
danoswaltCL
approved these changes
Jun 14, 2024
VivekFitkariwala
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logic for segment inclusion/exclusion of users.
This contains a new function getKeys() which returns the keys of all feature-flags the user can include provided the context.