Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature flag details link in table rows and to the details bread crumb #1571

Merged
merged 1 commit into from
May 23, 2024

Conversation

danoswaltCL
Copy link
Collaborator

Adds detail page routing from the table. And back to feature flag root from the bread crumbs. I couldn't figure out how to do the child routes in the manner of the other features (aka the <feature>.routing.module.ts files), but I also couldn't figure out why that would really matter? good luck if you'd like to try.

(This does not add any effects or calls yet to select the id or anything, just the routing)

@danoswaltCL danoswaltCL requested review from zackcl and Yagnik56 May 22, 2024 22:59
@danoswaltCL danoswaltCL merged commit 3f12bb8 into dev May 23, 2024
8 checks passed
@danoswaltCL danoswaltCL deleted the feature/add-routing-to-flag-details-and-back branch May 23, 2024 17:36
@Yagnik56 Yagnik56 linked an issue Jun 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants