Fixed bar chart color display. Specified variable types. #1462 #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ColorIndicators and conditionsFilterOptions(for correct display order). Updated variable types previously designated as 'any'.
RidhamShah
reviewed
May 14, 2024
...pp/features/dashboard/home/components/enrollment-over-time/enrollment-over-time.component.ts
Outdated
Show resolved
Hide resolved
Yagnik56
reviewed
May 14, 2024
ppratikcr7
reviewed
May 14, 2024
frontend/projects/upgrade/src/app/core/experiments/store/experiments.model.ts
Show resolved
Hide resolved
ppratikcr7
reviewed
May 14, 2024
frontend/projects/upgrade/src/app/core/experiments/store/experiments.model.ts
Show resolved
Hide resolved
ppratikcr7
reviewed
May 14, 2024
frontend/projects/upgrade/src/app/core/experiments/store/experiments.model.ts
Show resolved
Hide resolved
ppratikcr7
reviewed
May 14, 2024
.../features/dashboard/home/components/enrollment-over-time/enrollment-over-time.component.html
Outdated
Show resolved
Hide resolved
ppratikcr7
reviewed
May 14, 2024
...pp/features/dashboard/home/components/enrollment-over-time/enrollment-over-time.component.ts
Outdated
Show resolved
Hide resolved
ppratikcr7
reviewed
May 14, 2024
...pp/features/dashboard/home/components/enrollment-over-time/enrollment-over-time.component.ts
Show resolved
Hide resolved
ppratikcr7
reviewed
May 14, 2024
...pp/features/dashboard/home/components/enrollment-over-time/enrollment-over-time.component.ts
Show resolved
Hide resolved
ppratikcr7
requested changes
May 14, 2024
| @@ -91,7 +96,9 @@ export class EnrollmentOverTimeComponent implements OnChanges, OnInit, OnDestroy | |||
| this.experiment.conditions.forEach((condition) => { | |||
| this.conditionsFilterOptions.push({ code: condition.conditionCode, id: condition.id }); | |||
| this.selectedCondition.push(condition.id); | |||
| this.conditionsFilterOptions.sort((a, b) => a.code.localeCompare(b.code)); | |||
There was a problem hiding this comment.
The sort is done in every loop. This statement can be moved outside of the loop
There was a problem hiding this comment.
Moved sorting outside the loop
Yagnik56
approved these changes
May 22, 2024
VivekFitkariwala
approved these changes
May 27, 2024
ppratikcr7
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bar chart color display. Sorting the displaying graphData, graphColorIndicators and conditionsFilterOptions(for correct display order). Gave variable types previously designated as 'any'.