Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common-section-card component #1524

Merged
merged 4 commits into from
May 13, 2024

Conversation

zackcl
Copy link
Collaborator

@zackcl zackcl commented May 10, 2024

This PR creates a common section card component that renders header, content, and footer.

@zackcl zackcl requested review from Yagnik56 and danoswaltCL May 10, 2024 13:13
@zackcl zackcl self-assigned this May 10, 2024
@zackcl
Copy link
Collaborator Author

zackcl commented May 10, 2024

@danoswaltCL I applied the change you suggested to remove the hasFooter.

@danoswaltCL
Copy link
Collaborator

no base styles?

@zackcl
Copy link
Collaborator Author

zackcl commented May 10, 2024

@danoswaltCL I will create a separate PR to add the styles later.

@zackcl zackcl changed the title Add common-secion-card component Add common-section-card component May 10, 2024
Copy link
Collaborator

@Yagnik56 Yagnik56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@danoswaltCL danoswaltCL merged commit 9396235 into dev May 13, 2024
8 checks passed
@danoswaltCL danoswaltCL deleted the feature/common-section-card-component branch May 13, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants