Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue of user coming as undefined in audit logs #1457

Merged
merged 7 commits into from
Apr 29, 2024

Conversation

Yagnik56
Copy link
Collaborator

This PR address issue of user coming as undefined in audit logs.
Solution:
If user going as undefined, keep auth checker always on so if upgrad can't authenticate user it will log out user and audit logs won't get user as undefined.

@Yagnik56 Yagnik56 self-assigned this Apr 17, 2024
@Yagnik56 Yagnik56 linked an issue Apr 17, 2024 that may be closed by this pull request
Copy link
Collaborator

@VivekFitkariwala VivekFitkariwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are removing the environment variable authCheck from the code base. So also remove it from the file
env.ts
env.example
env.text

Check that there is no usage of authCheck anywhere.

At a comment in the Ticket describing the change

@Yagnik56 Yagnik56 merged commit fd58641 into dev Apr 29, 2024
8 checks passed
@Yagnik56 Yagnik56 deleted the bugfix/audit-logs-user-going-as-undefined branch April 29, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User names are missing in audit logs
2 participants