Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix client lib tester build errors #1437

Merged
merged 1 commit into from
Apr 10, 2024
+6 −318
Merged

fix client lib tester build errors #1437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion clientlibs/libTesters/client-lib-tester-frontend/src/app/app-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,4 @@ export const availableFrontendMockApps = [
MOCK_APP_NAMES.GENERAL_TS_FRONTEND_4_1,
MOCK_APP_NAMES.GENERAL_TS_FRONTEND_5_0,
MOCK_APP_NAMES.PORTAL_APP,
MOCK_APP_NAMES.MATHSTREAM_AdaptiveSegmentSwapExperiment,
];
14 changes: 6 additions & 8 deletions ...ter-frontend/src/app/mockFrontendClientAppComponents/general-test-for-version5.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { AbstractMockAppService } from './abstract-mock-app.service';
import { MOCK_APP_NAMES } from '../../../../shared/constants';
import { HttpClient } from '@angular/common/http';
import { lastValueFrom } from 'rxjs';
import { IUserAliases } from '../../../../../../types/src/Experiment/interfaces';

@Injectable({
providedIn: 'root',
Expand Down Expand Up @@ -382,8 +383,7 @@ export class GeneralTestForVersion5Service extends AbstractMockAppService {
console.error('User info is missing userAliases:', user);
}
try {
const useraliasesResponse: UpGradeClientInterfaces.IExperimentUserAliases[] =
await this.upgradeClient.setAltUserIds(user.userAliases);
const useraliasesResponse: IUserAliases = await this.upgradeClient.setAltUserIds(user.userAliases);
console.log({ useraliasesResponse });
} catch (err) {
console.error(err);
Expand All @@ -398,9 +398,8 @@ export class GeneralTestForVersion5Service extends AbstractMockAppService {
console.error('User info is missing groups:', user);
}
try {
const groupMembershipResponse: UpGradeClientInterfaces.IExperimentUser = await this.upgradeClient.setGroupMembership(
user.groups
);
const groupMembershipResponse: UpGradeClientInterfaces.IExperimentUser =
await this.upgradeClient.setGroupMembership(user.groups);
console.log({ groupMembershipResponse });
} catch (err) {
console.error(err);
Expand All @@ -415,9 +414,8 @@ export class GeneralTestForVersion5Service extends AbstractMockAppService {
console.error('User info is missing working groups:', user);
}
try {
const workingGroupMembershipResponse: UpGradeClientInterfaces.IExperimentUser = await this.upgradeClient.setWorkingGroup(
user.workingGroup
);
const workingGroupMembershipResponse: UpGradeClientInterfaces.IExperimentUser =
await this.upgradeClient.setWorkingGroup(user.workingGroup);
console.log({ workingGroupMembershipResponse });
} catch (err) {
console.error(err);
Expand Down
304 changes: 0 additions & 304 deletions ...ester-frontend/src/app/mockFrontendClientAppComponents/mock-mathstream-browser.service.ts
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions clientlibs/libTesters/client-lib-tester-frontend/src/app/services/mock-client-app.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { ClientLibraryService } from './client-library.service';
import { GeneralTestForVersion41Service } from '../mockFrontendClientAppComponents/general-test-for-version4-1.service';
import { GeneralTestForVersion1Service } from '../mockFrontendClientAppComponents/general-test-for-version1.service';
import { GeneralTestForVersion5Service } from '../mockFrontendClientAppComponents/general-test-for-version5.service';
import { MockMathstreamBrowserService } from '../mockFrontendClientAppComponents/mock-mathstream-browser.service';

@Injectable({
providedIn: 'root',
Expand All @@ -26,7 +25,6 @@ export class MockClientAppService {
public generalTest_1_1: GeneralTestForVersion1Service,
public generalTest_4_1: GeneralTestForVersion41Service,
public generalTest_5: GeneralTestForVersion5Service,
// public mathstream_AdaptiveSegmentSwapExperiment: MockMathstreamBrowserService,
public dataFetchService: DataFetchService,
public eventBus: EventBusService,
public clientLibraryService: ClientLibraryService
Expand All @@ -37,8 +35,6 @@ export class MockClientAppService {
[MOCK_APP_NAMES.GENERAL_TS_FRONTEND_1_1]: generalTest_1_1.getAppInterfaceModel(),
[MOCK_APP_NAMES.GENERAL_TS_FRONTEND_4_1]: generalTest_4_1.getAppInterfaceModel(),
[MOCK_APP_NAMES.GENERAL_TS_FRONTEND_5_0]: generalTest_5.getAppInterfaceModel(),
[MOCK_APP_NAMES.MATHSTREAM_AdaptiveSegmentSwapExperiment]:
mathstream_AdaptiveSegmentSwapExperiment.getAppInterfaceModel(),
};
}

Expand Down
1 change: 0 additions & 1 deletion clientlibs/libTesters/shared/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,4 @@ export const MOCK_APP_NAMES = {
GENERAL_TS_FRONTEND_5_0: 'General TS Browser v5.0',
BDAY_APP: 'Birthday App Browser',
PORTAL_APP: 'Mock Portal',
MATHSTREAM_AdaptiveSegmentSwapExperiment: 'Mathstream: AdaptiveSegmentSwapExperiment',
};
Loading