added the feature of search in segment section #1394
Conversation
There was a problem hiding this comment.
This works, but I wonder if we can encapsulate the filter logic into a reusable component - (I noticed that some of the method names were not changed when copied over to reflect the change from 'experiment' to 'filter')
The primary reason to make a filter component is that we're going to also need the same UI/functionality on the feature flags page, and we'd probably want to make sure all three (or more, possibly, in the future?) filters stay in sync if there are any changes later on.
|
@bcb37 there are few things which aren't same like achieved experiment and all aren't filtered on same properties so let's keep it this way for now, so this functionality start working. We will dig deep in UI feature flags as we are still figuring out how to implement reusable component and it will take a while to implement it so let's not keep this in hold till we get clarity on that. |
...rade/src/app/features/dashboard/segments/components/segments-list/segments-list.component.ts
Outdated
Show resolved
Hide resolved
...rade/src/app/features/dashboard/segments/components/segments-list/segments-list.component.ts
Outdated
Show resolved
Hide resolved
In segment section, search feature wasn't working as it wasn't implemented on input text-box. It is fixed now, search can be used now for all or based on particular value like name, context or status.