Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve UI bugs of validation loading spinner #1357

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Conversation

RidhamShah
Copy link
Collaborator

@RidhamShah RidhamShah commented Mar 12, 2024

Solved

For Import Experiment

  • Swagger for validation and import now called through POST
  • Swagger is updated to contain details of API
  • In UI, the import button for experiments will be disabled until validations are completed
  • Spinner will be shown while validations are processing for import
  • FIXED - Spamming the import button leads to multiple import calls resulting in multiple imports of the same files.

For import Segment

  • In UI, the import button for experiments will be disabled until validations are completed
  • Created spinner while validations are processing for import
  • FIXED - Spamming the import button leads to multiple import calls resulting in multiple imports of the same files.

@RidhamShah RidhamShah linked an issue Mar 14, 2024 that may be closed by this pull request
@RidhamShah RidhamShah marked this pull request as ready for review March 14, 2024 05:10
Copy link
Collaborator

@VivekFitkariwala VivekFitkariwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added one improvement in the comment.

@RidhamShah RidhamShah merged commit e52ab20 into dev Mar 15, 2024
8 checks passed
@RidhamShah RidhamShah deleted the fix/issue-1274-reopen branch March 15, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spinner loading is not working during validations
2 participants