debug statements in getExperimentCondition code #1356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danoswaltCL
commented
Mar 11, 2024
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| <!-- 5.0.12 -> 5.0.13: no retries for 4xx, retry other errors once instead of 3 times --> | |||
|
|
|||
| <version>5.0.13</version> | |||
| <version>5.0.13-DEBUG</version> | |||
There was a problem hiding this comment.
This will work as a version, right?
|
I think I figured out the NPE without needing this additional logging. But we can revisit if my theory turns out to be wrong. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if these logs look like reasonable spots to spy values for the
getExperimentConditionNPEs. If so I'll publish this branch from my local to Nexus, no need to merge anything in.