Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving snackbar errors #1076

Closed
wants to merge 4 commits into from
Closed

Conversation

RidhamShah
Copy link
Collaborator

No description provided.

@RidhamShah RidhamShah self-assigned this Oct 23, 2023
@RidhamShah RidhamShah linked an issue Oct 23, 2023 that may be closed by this pull request
@RidhamShah RidhamShah changed the base branch from dev to release/v5.0 October 23, 2023 12:21
@zackcl
Copy link
Collaborator

zackcl commented Oct 23, 2023

Is there a reason for replacing the MatSnackBar with angular2-notifications? I'm just curious.

@zackcl
Copy link
Collaborator

zackcl commented Oct 23, 2023

I've updated the design a little bit. Please let me know if you want me to update it further.

Screenshot 2023-10-23 at 6 17 25 PM

@amurphy-cl
Copy link
Collaborator

This looks great

@ppratikcr7
Copy link
Collaborator

Is there a reason for replacing the MatSnackBar with angular2-notifications? I'm just curious.

We were using both of them earlier. For network call errors we were using angular2-notifications and for success we were using MatSnackBar. But, now we decided to use only a single package angular2-notifications as it provides a nice queue system to stack the errors/success etc toast messages on top of one another to give a better readability. Also, the icons in the toast message is also good to have.

@ppratikcr7
Copy link
Collaborator

ppratikcr7 commented Oct 25, 2023

I've updated the design a little bit. Please let me know if you want me to update it further.

Screenshot 2023-10-23 at 6 17 25 PM

@zackcl There are various color coding for success/error/warn/info message type. Can you help out with deciding the correct css color and icons for them? @RidhamShah Maybe you can drop the screenshot with all of them showing at once?

@RidhamShah
Copy link
Collaborator Author

image
These are the updated snackBars for Success, Error, Warn, Info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error snackbar for validation errors on editing an experiment
4 participants