sub-segments of used segment will show as used in segments list #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yagnik56
requested review from
VivekFitkariwala,
bcb37,
ppratikcr7 and
danoswaltCL
bcb37
reviewed
Oct 11, 2023
| @@ -110,6 +110,24 @@ export class SegmentService { | |||
| }); | |||
| } | |||
|
|
|||
| segmentsData.forEach((segment) => { | |||
| segmentsUsedLockedList.forEach((usedSegment) => { | |||
| if (segment.id === usedSegment) { | |||
There was a problem hiding this comment.
We can replace this third-level loop with something like: segmentsUsedLockedList.push(...segment.subSegments.map(subSegment => subSegment.id))
and also below for the unlocked list.
There was a problem hiding this comment.
the second level loop can be replaced with an if condition
if(segmentUsedList.includes(segment.id))
| return { ...segment, status: SEGMENT_STATUS.USED }; // TODO change to locked | ||
| } else if (segmentsUsedUnlockedList.find((segmentId) => segmentId === segment.id)) { | ||
| return { ...segment, status: SEGMENT_STATUS.USED }; // TODO change to unlocked | ||
| } else if (segmentsUsedList.find((segmentId) => segmentId === segment.id)) { |
There was a problem hiding this comment.
Use includes over here also.
| @@ -85,38 +85,35 @@ export class SegmentService { | |||
| const allExperimentSegmentsInclusion = await this.getExperimentSegmenInclusionData(); | |||
| const allExperimentSegmentsExclusion = await this.getExperimentSegmenExclusionData(); | |||
There was a problem hiding this comment.
These three sequential awaits should be executed parallelly.
VivekFitkariwala
requested changes
Oct 12, 2023
https://github.com/CarnegieLearningWeb/UpGrade into bugfix/subsegments-of-used-segment-not-showed-as-used
VivekFitkariwala
approved these changes
Oct 16, 2023
Yagnik56
deleted the
bugfix/subsegments-of-used-segment-not-showed-as-used
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will resolve the issue of sub-segments of used segments not showing as used.