no retries on 4xx, max_retries=1 #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerith666 tagging you on this for awareness. Java lib is throwing retries without any strategy, which is sometimes generating a lot of extra meaningless error traffic and all the side-effects of it. This was spawned out of difficultly triaging the prod issues from last week, I am putting up a few changes in general to tamp down on snowballing error-state that our system sometimes gets into. I think this could be a major help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1047
This will need to get merged down into release/v4.1 then into release/v5.0, with new Java libs published for each.