Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: send status as string #1018

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

danoswaltCL
Copy link
Collaborator

If needed, alternative is to loosen type validation on the optional "status" param in mark.

Copy link
Contributor

@jerith666 jerith666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that this is necessary -- what's actually coming over the wire currently? I would've thought the underlying framework would call toString() or name() on the enum implicitly?

@jerith666
Copy link
Contributor

Oh, I see, the enum has a custom toString(); the framework is probably doing .name() and getting strings like CONDITION_APPLIED instead of the required condition applied. :(

@danoswaltCL
Copy link
Collaborator Author

ah-ha. yes CONDITION_APPLIED looks like what is coming across:

{"userId":"2f91780b-0362-44a3-b905-2874b9199bab","status":"CONDITION_APPLIED","data":{"site":"SelectSection","target":"volume_surface_area_cone_vol","assignedCondition":{"id":null,"conditionCode":null,"payload":null,"experimentId":null},"assignedFactor":null},"clientError":""}

@danoswaltCL danoswaltCL merged commit edd6a71 into release/v3.0.20 Sep 21, 2023
8 of 9 checks passed
@danoswaltCL danoswaltCL deleted the bugfix/send-status-as-string branch September 21, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants