solving preview user validations

CarnegieLearningWeb · Mar 4, 2024 · fd68208 · fd68208
1 parent 80ac904
commit fd68208
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/backend/packages/Upgrade/src/api/controllers/validators/PreviewUserValidator.ts b/backend/packages/Upgrade/src/api/controllers/validators/PreviewUserValidator.ts
@@ -1,11 +1,10 @@
-import { IsNotEmpty, IsDefined, ValidateNested, IsOptional, IsString, IsArray } from 'class-validator';
+import { ValidateNested, IsOptional, IsString, IsArray } from 'class-validator';
 import { Type } from 'class-transformer';
 import { Experiment } from '../../../../src/api/models/Experiment';
 import { ExperimentCondition } from '../../../../src/api/models/ExperimentCondition';
 
 class ExplicitIndividualAssignment {
-  @IsNotEmpty()
-  @IsDefined()
+  @IsOptional()
   @IsString()
   public id: string;
 

diff --git a/backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts b/backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
@@ -573,7 +573,7 @@ export class ExperimentAssignmentService {
       // Create new filtered experiment
       const alreadyAssignedExperiment = experimentPools.map((pool) => {
         return pool.filter((experiment) => {
-          const individualEnrollment = individualEnrollments.find((enrollment) => {
+          const individualEnrollment = mergedIndividualAssignment.find((enrollment) => {
             return enrollment.experiment.id === experiment.id;
           });
           const groupEnrollment = groupEnrollments.find((enrollment) => {