Skip to content

Commit

Permalink
Merge pull request #1081 from CarnegieLearningWeb/bugfix/1080-tempora…
Browse files Browse the repository at this point in the history
…rily-disable-error-tab

1080 disable errors tab
  • Loading branch information
zackcl authored Oct 25, 2023
2 parents efa371f + 782be76 commit e7d1d89
Show file tree
Hide file tree
Showing 10 changed files with 16 additions and 13 deletions.
2 changes: 1 addition & 1 deletion backend/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ab_testing_backend",
"version": "5.0.10",
"version": "5.0.11",
"description": "Backend for A/B Testing Project",
"scripts": {
"install:all": "npm ci && cd packages/Scheduler && npm ci && cd ../Upgrade && npm ci --legacy-peer-deps",
Expand Down
2 changes: 1 addition & 1 deletion backend/packages/Scheduler/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ppl-upgrade-serverless",
"version": "5.0.10",
"version": "5.0.11",
"description": "Serverless webpack example using Typescript",
"main": "handler.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion backend/packages/Upgrade/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ab_testing_backend",
"version": "5.0.10",
"version": "5.0.11",
"description": "Backend for A/B Testing Project",
"main": "index.js",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions clientlibs/java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
at the same time that happen to rev to the same new version will be caught
by a merge conflict. -->

<!-- 5.0.7 -> 5.0.10: Moving data and query in within subject code block for latency issue in QA (#1062) -->
<!-- 5.0.10 -> 5.0.11: 1080 temporarily hide error tab -->

<version>5.0.10</version>
<version>5.0.11</version>
<build>
<plugins>
<plugin>
Expand Down
2 changes: 1 addition & 1 deletion clientlibs/js/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "upgrade_client_lib",
"version": "5.0.10",
"version": "5.0.11",
"description": "Client library to communicate with the Upgrade server",
"files": [
"dist/*"
Expand Down
2 changes: 1 addition & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ab-testing",
"version": "5.0.10",
"version": "5.0.11",
"license": "MIT",
"scripts": {
"ng": "ng",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ export class ErrorLogsComponent implements OnInit, OnDestroy, AfterViewInit {
}

ngOnInit() {
// temporarily disabled

this.errorLogSubscription = this.logsService.getAllErrorLogs$.subscribe((errorLogs) => {
errorLogs.sort((a, b) => (a.createdAt > b.createdAt ? -1 : a.createdAt < b.createdAt ? 1 : 0));
this.errorLogData = groupBy(errorLogs, (log) => {
Expand All @@ -52,7 +54,7 @@ export class ErrorLogsComponent implements OnInit, OnDestroy, AfterViewInit {

fetchErrorLogOnScroll() {
if (!this.isAllErrorLogFetched) {
this.logsService.fetchErrorLogs();
this.logsService.fetchErrorLogs(); // temporarily disabled
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ <h1 class="ft-32-700 title">{{ 'logs.main-heading.text' | translate }}</h1>
<mat-tab [label]="'logs.audit-logs-tab.text' | translate">
<audit-logs></audit-logs>
</mat-tab>
<mat-tab [label]="'logs.error-logs-tab.text' | translate">
<!-- #1080 temporarily disable -->
<!-- <mat-tab [label]="'logs.error-logs-tab.text' | translate">
<error-logs></error-logs>
</mat-tab>
</mat-tab> -->
</mat-tab-group>

<mat-form-field class="log-filter">
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion types/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "upgrade_types",
"version": "5.0.10",
"version": "5.0.11",
"description": "",
"main": "src/index.ts",
"types": "src/index.ts",
Expand Down

0 comments on commit e7d1d89

Please sign in to comment.