adding csv data type as per review comments

CarnegieLearningWeb · Nov 4, 2024 · a7e1521 · a7e1521
1 parent 6bb9138
commit a7e1521
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/backend/packages/Upgrade/src/api/repositories/AnalyticsRepository.ts b/backend/packages/Upgrade/src/api/repositories/AnalyticsRepository.ts
@@ -99,12 +99,12 @@ export interface ExperimentCSVData {
   postRule: string;
   enrollmentStartDate: string;
   enrollmentCompleteDate: string;
-  revertTo: string;
-  payload: string;
-  excludeIfReached: boolean;
-  expDecisionPointId: string;
-  expConditionId: string;
-  conditionName: string;
+  revertTo?: string;
+  payload?: string;
+  excludeIfReached?: boolean;
+  expDecisionPointId?: string;
+  expConditionId?: string;
+  conditionName?: string;
   details: ConditionDecisionPointData[];
 }
 

diff --git a/backend/packages/Upgrade/src/api/services/AnalyticsService.ts b/backend/packages/Upgrade/src/api/services/AnalyticsService.ts
@@ -15,7 +15,7 @@ import {
   SERVER_ERROR,
   IExperimentEnrollmentStats,
 } from 'upgrade_types';
-import { AnalyticsRepository, CSVExportDataRow } from '../repositories/AnalyticsRepository';
+import { AnalyticsRepository, CSVExportDataRow, ExperimentCSVData } from '../repositories/AnalyticsRepository';
 import { Experiment } from '../models/Experiment';
 import ObjectsToCsv from 'objects-to-csv';
 import fs from 'fs';
@@ -183,7 +183,7 @@ export class AnalyticsService {
         throw new HttpError(404, `Experiment not found for id: ${experimentId}`);
       }
       const formattedExperiments = experimentQueryResult.reduce((acc, item) => {
-        let experiment = acc.find((e) => e.experimentId === item.experimentId);
+        let experiment: ExperimentCSVData = acc.find((e) => e.experimentId === item.experimentId);
         if (!experiment) {
           experiment = {
             experimentId: item.experimentId,