style changes to move UI closer to figma design and bugfix (#1761)

Co-authored-by: danoswaltCL <[email protected]>
CarnegieLearningWeb · Jul 16, 2024 · 907ea12 · 907ea12
1 parent 5b4f186
commit 907ea12
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 11 deletions.
diff --git a/...shboard/feature-flags/modals/add-feature-flag-modal/add-feature-flag-modal.component.scss b/...shboard/feature-flags/modals/add-feature-flag-modal/add-feature-flag-modal.component.scss
@@ -3,7 +3,7 @@
   flex-direction: column;
   align-items: space-between;
   width: 100%;
-  height: 600px;
+  max-height: 700px;
 }
 
 .title {

diff --git a/...board/feature-flags/modals/edit-feature-flag-modal/edit-feature-flag-modal.component.scss b/...board/feature-flags/modals/edit-feature-flag-modal/edit-feature-flag-modal.component.scss
@@ -3,7 +3,7 @@
   flex-direction: column;
   align-items: space-between;
   width: 100%;
-  height: 600px;
+  max-height: 700px;
 }
 
 .title {

diff --git a/...onent-lib/components/common-details-page-header/common-details-page-header.component.html b/...onent-lib/components/common-details-page-header/common-details-page-header.component.html
@@ -1,7 +1,8 @@
 <ng-container class="header">
   <div class="ft-14-400 breadcrumb">
-    <a [routerLink]="['/', rootLink]" class="root-link">{{ rootName | translate }} </a>
-    >
-    <span class="details-name">{{ detailsName | translate }}</span>
+    <span>
+      <a [routerLink]="['/', rootLink]" class="root-link">{{ rootName | translate }} </a>
+      > <b>{{ detailsName | translate }}</b>
+    </span>
   </div>
 </ng-container>
diff --git a/...onent-lib/components/common-details-page-header/common-details-page-header.component.scss b/...onent-lib/components/common-details-page-header/common-details-page-header.component.scss
@@ -7,10 +7,10 @@
   .breadcrumb {
     display: flex;
     column-gap: 8px;
+    color: var(--light-black);
 
-    .root-link,
-    .details-name {
-      color: var(--light-black);
+    .root-link {
+      text-decoration: none;
     }
   }
 }
diff --git a/...e-component-lib/components/common-root-page-header/common-root-page-header.component.scss b/...e-component-lib/components/common-root-page-header/common-root-page-header.component.scss
@@ -1,5 +1,5 @@
 ::ng-deep .header {
-  height: 112px;
+  min-height: 112px;
   display: flex;
   flex-direction: column;
   justify-content: center;

diff --git a/frontend/projects/upgrade/src/app/shared/services/common-dialog.service.ts b/frontend/projects/upgrade/src/app/shared/services/common-dialog.service.ts
@@ -128,7 +128,6 @@ export class DialogService {
     const config: MatDialogConfig = {
       data: commonModalConfig,
       width: '670px',
-      height: '390px',
       autoFocus: 'input',
       disableClose: true,
     };
@@ -145,7 +144,6 @@ export class DialogService {
     const config: MatDialogConfig = {
       data: commonModalConfig,
       width: '670px',
-      height: '460px',
       autoFocus: 'input',
       disableClose: true,
     };