Revert "solved design page getting disabled error"

This reverts commit 109ad54.
CarnegieLearningWeb · Apr 27, 2023 · 6aaeb22 · 6aaeb22
1 parent 9e5eb41
commit 6aaeb22
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 11 deletions.
diff --git a/...jects/upgrade/src/app/core/experiment-design-stepper/experiment-design-stepper.service.ts b/...jects/upgrade/src/app/core/experiment-design-stepper/experiment-design-stepper.service.ts
@@ -547,11 +547,10 @@ export class ExperimentDesignStepperService {
     this.store$.dispatch(actionUpdateFactorialConditionTableData({ tableData }));
   }
 
-  setUpdatePayloadTableEditModeDetails(rowIndex: number | null, isNgDestroyCall: boolean): void {
+  setUpdatePayloadTableEditModeDetails(rowIndex: number | null): void {
     this.store$.dispatch(
       experimentDesignStepperAction.actionToggleSimpleExperimentPayloadTableEditMode({
         simpleExperimentPayloadTableEditIndex: rowIndex,
-        isNgDestroyCall: isNgDestroyCall,
       })
     );
   }

diff --git a/...upgrade/src/app/core/experiment-design-stepper/store/experiment-design-stepper.actions.ts b/...upgrade/src/app/core/experiment-design-stepper/store/experiment-design-stepper.actions.ts
@@ -46,7 +46,6 @@ export const actionToggleSimpleExperimentPayloadTableEditMode = createAction(
   '[Experiment-Design-Stepper] Update Simple Experiment Payload Table Edit Mode Details',
   props<{
     simpleExperimentPayloadTableEditIndex: number | null;
-    isNgDestroyCall: boolean;
   }>()
 );
 

diff --git a/...upgrade/src/app/core/experiment-design-stepper/store/experiment-design-stepper.reducer.ts b/...upgrade/src/app/core/experiment-design-stepper/store/experiment-design-stepper.reducer.ts
@@ -73,12 +73,9 @@ const reducer = createReducer(
   })),
   on(
     experimentDesignStepperAction.actionToggleSimpleExperimentPayloadTableEditMode,
-    (state, { simpleExperimentPayloadTableEditIndex, isNgDestroyCall }): ExperimentDesignStepperState => {
+    (state, { simpleExperimentPayloadTableEditIndex }): ExperimentDesignStepperState => {
       // toggle edit mode
-      let editMode: boolean;
-      if (!isNgDestroyCall) {
-        editMode = !state.isSimpleExperimentPayloadTableEditMode;
-      }
+      const editMode = !state.isSimpleExperimentPayloadTableEditMode;
 
       // if not in edit mode, use null for row-index
       const editIndex = editMode ? simpleExperimentPayloadTableEditIndex : null;

diff --git a/...es/dashboard/home/components/experiment-design/payloads-table/payloads-table.component.ts b/...es/dashboard/home/components/experiment-design/payloads-table/payloads-table.component.ts
@@ -50,8 +50,7 @@ export class PayloadsTableComponent implements OnInit, OnDestroy {
   }
 
   ngOnDestroy(): void {
-    this.experimentDesignStepperService.clearSimpleExperimentDesignStepperData();
-    this.experimentDesignStepperService.setUpdatePayloadTableEditModeDetails(null, true);
+    this.experimentDesignStepperService.setUpdatePayloadTableEditModeDetails(null);
     this.subscriptions.unsubscribe();
   }
 
@@ -119,7 +118,7 @@ export class PayloadsTableComponent implements OnInit, OnDestroy {
     }
 
     this.currentPayloadInput$.next(rowData.payload);
-    this.experimentDesignStepperService.setUpdatePayloadTableEditModeDetails(rowIndex, false);
+    this.experimentDesignStepperService.setUpdatePayloadTableEditModeDetails(rowIndex);
     this.experimentDesignStepperService.setNewSimpleExperimentPayloadTableData(payloadTableData);
   }
-Original file line number
+Diff line change
@@ Expand Up @@
       '[Experiment-Design-Stepper] Update Simple Experiment Payload Table Edit Mode Details',
       props<{
         simpleExperimentPayloadTableEditIndex: number | null;
-        isNgDestroyCall: boolean;
       }>()
     );
@@ Expand Down @@