Bugfix/importing bulk experiments (#857)

* fixed issue coming in importing experiments in bulk * resolve testcase fail
CarnegieLearningWeb · May 24, 2023 · 54ea501 · 54ea501
1 parent 6138511
commit 54ea501
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/backend/packages/Upgrade/src/api/services/SegmentService.ts b/backend/packages/Upgrade/src/api/services/SegmentService.ts
@@ -229,7 +229,7 @@ export class SegmentService {
       // create/update segment document
       segment.id = segment.id || uuid();
       const { id, name, description, context, type } = segment;
-      const allSegments = await this.segmentRepository.getAllSegments(logger);
+      const allSegments = await this.getSegmentByIds(segment.subSegmentIds);
       const subSegmentData = segment.subSegmentIds
         .filter((subSegmentId) => {
           // check if segment exists:

diff --git a/backend/packages/Upgrade/test/unit/services/SegmentService.test.ts b/backend/packages/Upgrade/test/unit/services/SegmentService.test.ts
@@ -267,7 +267,7 @@ describe('Segment Service Testing', () => {
   it('should upsert a segment with no id', async () => {
     const err = new Error('error');
     const segment = new SegmentInputValidator();
-    segment.subSegmentIds = ['seg3'];
+    segment.subSegmentIds = ['seg1'];
     segment.userIds = [];
     segment.groups = [];
     repo.findOne = jest.fn().mockResolvedValue(seg2);