Skip to content

Commit

Permalink
allow null in type for condition
Browse files Browse the repository at this point in the history
  • Loading branch information
danoswaltCL committed Sep 25, 2023
1 parent f372c41 commit 4e935c2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion clientlibs/js/src/UpgradeClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ export default class UpgradeClient {

async markExperimentPoint(
site: string,
condition: string = null,
condition: string | null = null,
status: MARKED_DECISION_POINT_STATUS,
target?: string,
clientError?: string
Expand Down
4 changes: 2 additions & 2 deletions clientlibs/js/src/functions/markExperimentPoint.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ interface markData {
status: MARKED_DECISION_POINT_STATUS;
data: {
site: string;
assignedCondition: { conditionCode: string; experimentId?: string },
assignedCondition: { conditionCode: string | null; experimentId?: string },
target?: string;
}
clientError?: string;
Expand All @@ -19,7 +19,7 @@ export default async function markExperimentPoint(
token: string,
clientSessionId: string,
site: string,
condition: string,
condition: string | null,
status: MARKED_DECISION_POINT_STATUS,
target?: string,
clientError?: string
Expand Down

0 comments on commit 4e935c2

Please sign in to comment.