Added android pinch gesture #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added scaling (pinch gesture) to only android smartphones
CariusLars
requested changes
Jul 4, 2022
| try { | ||
| when (dict_node["type"] as Int) { | ||
| 0 -> { // GLTF2 Model from Flutter asset folder | ||
| // Get path to given Flutter asset | ||
| val loader: FlutterLoader = FlutterInjector.instance().flutterLoader() | ||
| val key: String = loader.getLookupKeyForAsset(dict_node["uri"] as String) | ||
|
|
||
| println("FREDTAP2: added model: ") |
| node.getRenderable()?.setMaterial(x,m); | ||
| }*/ | ||
| // node.getRenderable()?.getMaterial().setFloat4("baseColorFactor", 1,1,1,1) | ||
| println("3a LOADED RENDERABLE " + node.getRenderable()?.getMaterial().toString()) |
| anchorNode.addChild(node) | ||
| completableFutureSuccess.complete(true) | ||
| println("4 LOADED RENDERABLE " + node.getRenderable()?.getSubmeshCount().toString()) |
| anchorNode.addChild(node) | ||
| completableFutureSuccess.complete(true) | ||
| println("4 LOADED RENDERABLE " + node.getRenderable()?.getSubmeshCount().toString()) | ||
| println("5 LOADED RENDERABLE " + node.getRenderable()?.getSubmeshCount().toString()) |
| } else { | ||
| completableFutureSuccess.complete(false) | ||
| } | ||
| } else { | ||
| arSceneView.scene.addChild(node) | ||
| val mainHandler = Handler(viewContext.mainLooper) | ||
| val runnable = Runnable {sessionManagerChannel.invokeMethod("onError", listOf("2 LOADED RENDERABLE " + node )) } |
There was a problem hiding this comment.
I don't think we want this hard-coded in here
| @@ -776,7 +813,8 @@ internal class AndroidARView( | |||
| } catch (e: java.lang.Exception) { | |||
| completableFutureSuccess.completeExceptionally(e) | |||
| } | |||
|
|
|||
| println("FREDTAP: added model: ") | |||
| val completableFutureNode: CompletableFuture<CustomTransformableNode> = CompletableFuture() | ||
|
|
||
| val gltfNode = CustomTransformableNode(transformationSystem, objectManagerChannel, enablePans, enableRotation) | ||
| println("MAKENODEFROMGLTF: ") |
lib/managers/ar_object_manager.dart
Outdated
| @@ -136,7 +164,9 @@ class ARObjectManager { | |||
| } else { | |||
| return await _channel.invokeMethod<bool>('addNode', node.toMap()); | |||
| } | |||
| print("before exception"); | |||
|
requested a few changes, I also think the iOS version should be added before we can merge this to stay true to the cross-platform approach of this plugin. Any volunteers? |
|
Why is this only Android based? why is there no iOS counterpart? |
|
Sry i overlooked this changes. I have chnaged it now. The reason why no IOS support is because i cannot test it because i have no iphone at home :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added scaling (pinch gesture) to only android smartphones