Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New release to remove compilation warnings? #68

Closed
thbar opened this issue Jul 6, 2021 · 1 comment
Closed

New release to remove compilation warnings? #68

thbar opened this issue Jul 6, 2021 · 1 comment

Comments

@thbar
Copy link
Contributor

thbar commented Jul 6, 2021

I was investigating on the following compilation warnings:

==> vex
Compiling 25 files (.ex)
warning: do not use "length(errors) > 0" to check if a list is not empty since length always traverses the whole list. Prefer to pattern match on a non-empty list, such as [_ | _], or use "errors != []" as a guard
  lib/vex.ex:15

warning: module attribute @only was set but never used
  lib/vex/blank.ex:2

Generated vex app

I believe that these are already solved on master thanks to the work done here #57.

Is there anyone in capacity to issue a new release maybe? Thanks!
@thbar thbar mentioned this issue Jul 6, 2021
Closed
19 tasks
@jfornoff
Copy link
Collaborator

jfornoff commented Jul 7, 2021

Released v0.9

@jfornoff jfornoff closed this as completed Jul 7, 2021
thbar added a commit to etalab/transport-site that referenced this issue Aug 31, 2023
@thbar
Go back to mainstream vex (now fixed)
4bd34b2 
Fix at:
- CargoSense/vex#68
github-merge-queue bot pushed a commit to etalab/transport-site that referenced this issue Aug 31, 2023
@thbar
Mises à jour techniques (Elixir 1.15, packages Hex...) (#3429)
1e86025 
* Bump appsginal, ex_phone_number, hackney, sentry

* Bump dialyxir

* Bump more stuff

* Fix broken test

* Bump ymlr (major but apparently passing)

* Bump phoenix_html yarn package

* Bump more stuff

* Bump Elixir & NodeJS

* Try to fix `function Dialyxir.Output.info/1 is undefined (module Dialyxir.Output is not available)`

* Fix warning

* Try to fix dialyzer error

* Try to fix Dialyzer error

See jeremyjh/dialyxir#508 (comment)

* Mix format (1.15)

* Update phoenix_live_view package

* Fix warnings

* Bump jumper

* Bump unsafe

* Bump sweet_xml

* Bump dialyxir

* Go back to mainstream vex (now fixed)

Fix at:
- CargoSense/vex#68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thbar @jfornoff