This repository has been archived by the owner on Jul 23, 2021. It is now read-only.
forked from rjsf-team/react-jsonschema-form
-
Notifications
You must be signed in to change notification settings - Fork 7
Update with latest code from the original repository. #58
Merged
jnorris-carecloud
merged 35 commits into
CareCloud:develop
from
jnorris-carecloud:update-from-mozilla
Jul 2, 2018
Merged
Update with latest code from the original repository. #58
jnorris-carecloud
merged 35 commits into
CareCloud:develop
from
jnorris-carecloud:update-from-mozilla
Jul 2, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay operation when live validation is off.
In the example, the `onSubmit` function receives a `formData` obj. However, the actual data is in `formData.formData`. While this is explained in the docs, I propose making it clearer in the example as well.
If you want to change how your FieldTemplate is rendered based on ui:disabled, you currently have to check `uiSchema["ui:disabled"]`, which is unlike the pattern for `readonly` and other known `ui:*` settings.
* Failing test for enum without type (rjsf-team#66 rjsf-team#611) * Proposed fix for enum without type (rjsf-team#66 rjsf-team#611) * PR feedback - getSchemaType function https://github.com/mozilla-services/react-jsonschema-form/pull/668/files#r133395455
According to https://github.com/mozilla-services/react-jsonschema-form/blob/master/src/components/fields/ArrayField.js#L224 `onAddClick` is not returning function as specified in the documentation.
* Priori should by prior, I think * Italicizing a priori based on suggestion
…sonschema-form into knilink-error-schema-array
* pass raw errors to field widgets * fixed formatting * fixing line endings * Pass raw errors into Field at creation; object destructuring; added test for passing of raw errors; removed unused prop from ArrayField. * fix lineEndings
* Move to the 3.x series of react-codemirror2 * Move to the 4.x series of react-codemirror2 See scniro/react-codemirror2#63 for more details.
hcuneo-carecloud
approved these changes
Jun 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
nsecchi-carecloud
approved these changes
Jun 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.carecloud.com/browse/EAG-1172