Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A0-2073] Update dependencies to stable ink4. #968

Closed
wants to merge 2 commits into from

Conversation

deuszx
Copy link
Collaborator

@deuszx deuszx commented Mar 6, 2023

Updates aleph_client and cliain to use stable versions of contract-* crates used for interacting with the chain.

Updates contracts' in /contracts repository to use stable ink4 release (instead of beta).

@deuszx deuszx force-pushed the update-benjamin-ink4-stable branch from 7ebd9c5 to 1ad7b52 Compare March 6, 2023 15:32
@deuszx deuszx changed the title Update contracts to stable ink4. Update dependencies to stable ink4. Mar 6, 2023
@deuszx deuszx changed the title Update dependencies to stable ink4. [A0-2073] Update dependencies to stable ink4. Mar 6, 2023
Copy link
Member

@h4nsu h4nsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're doing the "super-hard-freeze" with ~, we could consider going with the most recent version (~4.0.1) rather than 4.0.0. Just a suggestion, probably doesn't make much difference

@deuszx
Copy link
Collaborator Author

deuszx commented Mar 6, 2023

If we're doing the "super-hard-freeze" with ~, we could consider going with the most recent version (~4.0.1) rather than 4.0.0. Just a suggestion, probably doesn't make much difference

~4.0.0 should mean it's >= 4.0.0 and < 4.1.0 if I'm reading correctly: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html

@deuszx deuszx force-pushed the update-benjamin-ink4-stable branch from 1ad7b52 to 3cf1851 Compare March 8, 2023 22:52
@deuszx
Copy link
Collaborator Author

deuszx commented Mar 9, 2023

Superseeded by #995

@deuszx deuszx closed this Mar 9, 2023
@deuszx deuszx deleted the update-benjamin-ink4-stable branch March 13, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants