Update mempool example to v6.x #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
reviewed
Jun 6, 2024
Comment on lines
+114
to
117
| const message = JSON.parse(e); | ||
| if (message?.result?.transaction === null) { | ||
| rpc('acquireMempool'); | ||
| } else { |
There was a problem hiding this comment.
I am not sure I understand the rationale behind this change here? Why change the behavior an re-acquire a snapshot?
There was a problem hiding this comment.
My understanding is that in the current behavior when the code runs while the mempool is empty, then no transactions will be displayed and client.close() will cause the the script to exit. This happened to me when I ran it the first time (preview testnet) and I wasn't sure if I'd done something wrong.
The new code behaves similarly to the starter kit example where it loops indefinitely and waits for new transactions to come in.
KtorZ
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update local-tx-monitor example