Skip to content

Commit

Permalink
Merge pull request #60 from CaptainFact/comradekingu-patch-1
Browse files Browse the repository at this point in the history
Language reworked
  • Loading branch information
Betree authored Jun 29, 2019
2 parents a689ac1 + fac9b0e commit 6113ecb
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@

## Install

| **Chrome** | **Firefox** | **Opera** | **Safari** | **IE** |
| **Chrome** | **Firefox** | **Opera** | **Safari** | **EDGE** |
| ----------------- | ------------------ | -------------------------------- | ----------------- | ------------- |
| [Available][0] | [Available][1] | Works with [Chrome extension][0] | Not yet | Not yet |

Expand Down Expand Up @@ -76,33 +76,33 @@ their respective scores.
* Run:
* `./captain-fact-overlay-injector/dev/start_graphql_api.sh` - Start the GraphQL API. You can access GraphiQL at http://localhost:4002/graphiql
* `npm start` - Start the overlay injector test pages on http://localhost:3342
* `npm run test` - run all unit tests
* `npm run test` - Runs all unit tests

## FAQ

* Why do you need storage permissions ?
* Why do you need storage permissions?

We store a local cache of videos ids that exist on CaptainFact. This cache gets updated when you visit Youtube
We store a local cache of videos IDs that exist on CaptainFact. This cache gets updated when you visit YouTube
if it's older than 15 minutes. This is a privacy improvement that guarantees we don't track the videos you're
watching and don't send unnecessary requests.

* Why do you need tabs permissions ?
* Why do you need tab permissions?

Because we inject script programmatically from background (only if video is known from cache) and
to be able to disable CaptainFact on all tabs when you unselect it from extension popup.
Because the script is injected programmatically in the background (only if video is known from cache) and
to be able to turn off CaptainFact on all tabs when you unselect it from the extension popup.

You can check by yourself in `chrome/extension/background.js` (look for `chrome.tabs.`)

* Why do you need Youtube permissions ?
* Why do you need Youtube permissions?

To be able to inject the facts overlay on Youtube videos.
To be able to inject the facts overlay on YouTube videos.

* Why do you only inject on youtube.com and not in embedded players everywhere else ?
* Why do you only inject on youtube.com and not in embedded players everywhere else?

We may want to implement this in a separate release in the future. We don't want to implement
this feature in main extension cause it means asking for permissions to access all your sites.

* Can I add sources on videos directly from the extension ?
* Can I add sources on videos directly from the extension?

Not at the moment.

Expand Down

0 comments on commit 6113ecb

Please sign in to comment.