Add rate limit to confighttp #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallyx3
reviewed
Sep 28, 2023
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| err := limiter.Take(r.Context(), r.URL.Path, r.Header) | ||
| if err != nil { | ||
| http.Error(w, http.StatusText(http.StatusTooManyRequests), http.StatusTooManyRequests) |
There was a problem hiding this comment.
Do we want to support a condition where err is not nil but its also not a rate limited error either?
Would we want to be able to surface other runtime errors via the interceptor or should we surface it another way?
There was a problem hiding this comment.
I also thought about it. in-memory limiter, which is a backoff limiter, will not return any errors other than rate-limited. So I was wondering if I need an extra condition in here?
There was a problem hiding this comment.
Hmm the in memory limiter could still return other errors. Like for instance there could be runtime errors from misconfiguration (ie a default limiter not being set for a limiter type).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
HLDD
For tests, I followed the same structure as other tests in the package (very similar to ServerAuth tests).