Lower Go version to 1.20 for plugin #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build system for the kinesis plugin is rather complex - in short, we pull this code into an AWS AL2 based container where Go is installed, compile the plugin and then copy it out for inclusion in our own image. This means that the minimum Go version specified in this code must be no higher than the Go version available in the AWS AL2 image (which is currently Go 1.20). Unfortunately this version is no longer receiving reliability or security updates, but we'll have to deal with this issue in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build system for the kinesis plugin is rather complex - in short, we
pull this code into an AWS AL2 based container where Go is installed,
compile the plugin and then copy it out for inclusion in our own image.
This means that the minimum Go version specified in this code must be
no higher than the Go version available in the AWS AL2 image (which is
currently Go 1.20). Unfortunately this version is no longer receiving
reliability or security updates, but we'll have to deal with this issue
in the future.