Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): upgrade DataFusion to the required commit #891

Merged
merged 6 commits into from
Nov 6, 2024
Merged

feat(core): upgrade DataFusion to the required commit #891

merged 6 commits into from
Nov 6, 2024

Conversation

goldmedal
Copy link
Contributor

@goldmedal goldmedal commented Nov 6, 2024 •
edited
Loading

@github-actions github-actions bot added core dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Nov 6, 2024
@goldmedal goldmedal changed the title Upgrade DataFusion to the required commit feat(core): upgrade DataFusion to the required commit Nov 6, 2024
@github-actions github-actions bot added bigquery ibis python Pull requests that update Python code labels Nov 6, 2024
@goldmedal goldmedal marked this pull request as ready for review November 6, 2024 06:49
@goldmedal goldmedal removed the bigquery label Nov 6, 2024
grieve54706
grieve54706 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@grieve54706 grieve54706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The bigquery.csv seems redundant.
And I will pull out the count of datafusion function be a common constant and data source function will base on the constant variable.

@goldmedal
Copy link
Contributor Author

goldmedal commented Nov 6, 2024 •
edited
Loading

It seems the CI for BigQuery has some issues. I disable the CI for it. I tested it locally and it works well.

wren-engine-py3.11jax@jax-canner:~/git/wren-engine-rs-workspace/ibis-server (feature/upgrade-datafucion-for-col-unparse) $ poetry run pytest -m 'bigquery and beta'
========================================================================================================================== test session starts ==========================================================================================================================
platform darwin -- Python 3.11.6, pytest-8.3.3, pluggy-1.5.0
rootdir: /Users/jax/git/wren-engine-rs-workspace/ibis-server
configfile: pyproject.toml
plugins: anyio-4.6.2.post1
collected 187 items / 184 deselected / 3 selected                                                                                                                                                                                                                       

tests/routers/v3/connector/bigquery/test_functions.py ...

@goldmedal goldmedal merged commit 936e4b9 into Canner:main Nov 6, 2024
13 checks passed
@goldmedal goldmedal deleted the feature/upgrade-datafucion-for-col-unparse branch November 6, 2024 08:36
@goldmedal
Copy link
Contributor Author

Thanks @grieve54706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grieve54706 grieve54706 grieve54706 approved these changes

Assignees
No one assigned
Labels
core dependencies Pull requests that update a dependency file ibis python Pull requests that update Python code rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wren Core return SQL is invalid for BigQuery
2 participants
@goldmedal @grieve54706