Add Dockerfile and build image flow #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grieve54706
force-pushed
the
feature/ibis/docker-image
branch
from
715b833
to
0869e2f
Compare
grieve54706
force-pushed
the
feature/ibis/docker-image
branch
from
0c77b7c
to
10f96bf
Compare
If we install the dependencies in the CI, may cause platform issue
grieve54706
force-pushed
the
feature/ibis/docker-image
branch
from
5cb20db
to
4bbbda0
Compare
goldmedal
approved these changes
May 28, 2024
ibis-server/README.md
Outdated
| make run | ||
| ``` | ||
|
|
||
| ## Contributing |
There was a problem hiding this comment.
Suggested change
| ## Contributing | |
| ## Developer Guide |
It's a kind of guide to show how start a development environment for developers.
I think Developer Guide would be better.
| docker-build: | ||
| docker image build . -t wren-engine-ibis | ||
|
|
||
| docker-run: |
There was a problem hiding this comment.
Suggested change
| docker-run: | |
| dev-docker-run: |
How about add a dev prefix? I guess someone maybe confuse on which version would be started by this command. The image on repo? or The local build.
I guess this one will start the local one, right?
paopa
approved these changes
May 28, 2024
Comment on lines
+54
to
+61
| - name: Docker meta | ||
| id: meta | ||
| uses: docker/metadata-action@v5 | ||
| with: | ||
| images: ghcr.io/canner/wren-engine-ibis | ||
| tags: | | ||
| type=sha | ||
| type=raw,value=nightly |
There was a problem hiding this comment.
First time to know this action to put the image tags. it's really concise!
|
Thanks @grieve54706 @paopa |
goldmedal
pushed a commit
that referenced
this pull request
May 28, 2024
* Add Dockerfile * Make ibis version same as java engine * Add CI Install python dependencies in the CI * Make python dependencies install in the Docker If we install the dependencies in the CI, may cause platform issue * Use docker/build-push-action * Fix tag name * Add docker/metadata-action * Fix Dockerfile path * Fix context * Fix tag * Update README * Remove invalid default working-directory * Fix pyproject.toml path * Use step.working-directory * Use poetry version * Add empty line in the end of file * Edit title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Dockefile and GitHub workflow to build images.
Additional information
This PR uses
pull_requestlabeledevent to test. Please ignore the manytestlabel messages.We may use the event
on.push.branchesto test the GitHub workflow in the future.