Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored pr #34

Merged
merged 12 commits into from
Oct 2, 2024
Merged

Conversation

cphelefu
Copy link
Member

@cphelefu cphelefu commented Sep 27, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #30
Fixes #35
Fixes #36
Fixes #28

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

https://github.com/cphelefu/geoview-demo

Checklist:

  • I have build (npm run build) and deploy (npm run deploy) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@jolevesq jolevesq merged commit db84f61 into Canadian-Geospatial-Platform:develop Oct 2, 2024
5 of 6 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
github-actions bot pushed a commit to cphelefu/geoview-demo that referenced this pull request Oct 2, 2024
…rom cphelefu/refactored-pr

Refactored pr
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants