Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change readme instructions to run build and run preview #11

Conversation

Pewillia
Copy link
Member

@Pewillia Pewillia commented Sep 18, 2024

(10)

Description

.change readme instructions to run build and run preview, fix spelling

Fixes # (10) change readme instructions to run build and run preview

Type of change

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

https://pewillia.github.io/geoview-demo/?config=01-basemap-LCC-TLS.json

Checklist:

  • I have build (npm run build) and deploy (npm run deploy) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [x ] My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Pewillia Pewillia force-pushed the 10-change-readme-instructions branch 2 times, most recently from 1e000fb to 9ffa4e6 Compare September 24, 2024 14:49
@Pewillia Pewillia force-pushed the 10-change-readme-instructions branch 2 times, most recently from 9c808e4 to 4dd0456 Compare October 4, 2024 18:33
@Pewillia Pewillia requested a review from jolevesq October 4, 2024 18:56
@Pewillia Pewillia self-assigned this Oct 4, 2024
@Pewillia Pewillia force-pushed the 10-change-readme-instructions branch from 4dd0456 to af6d5ce Compare October 11, 2024 21:12
@jolevesq jolevesq merged commit cfc7b5f into Canadian-Geospatial-Platform:develop Oct 17, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants