Oval crop corners added #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added provision to add Oval crop corners when the crop style is Rectangle 2. Setters exposed to had crop corner radius and fill color
Canato
reviewed
Jan 25, 2022
cropper/src/main/java/com/canhub/cropper/CropImageContractOptions.kt
Outdated
Show resolved
Hide resolved
cropper/src/main/java/com/canhub/cropper/CropImageContractOptions.kt
Outdated
Show resolved
Hide resolved
|
@bhagyae5308 the CI is not passing, could you take a look please? Maybe worth check the CONTRIBUTING for the code style |
|
@Canato Apologies for late update, I was occupied with some other tasks. |
Canato
requested changes
Feb 2, 2022
|
|
||
| /** | ||
| * To set the fill color of the Oval crop corner | ||
| * @param circleFillColorHexValue Hex value of the color (Default is MAGENTA) |
There was a problem hiding this comment.
Let's change the default to White please
| @@ -531,6 +568,8 @@ class CropOverlayView | |||
| canvas | |||
| ) | |||
| } | |||
| // To retain the changes in Paint object when the App goes background this is required | |||
| mBorderCornerPaint = getNewPaintOrNull(mOptions?.borderCornerThickness ?: 0.0f, mOptions?.borderCornerColor ?: Color.WHITE) | |||
| @@ -52,6 +52,9 @@ | |||
| <include | |||
| android:id="@+id/cropShape" | |||
| layout="@layout/chip_crop_shape" /> | |||
| <include android:id="@+id/cornerShape" | |||
| layout="@layout/chip_corner_shape" | |||
| android:visibility="gone"/> | |||
There was a problem hiding this comment.
Nice touch. Can see you are a detailed dev, thanks for it
bhagyae5308
commented
Feb 2, 2022
| @@ -908,28 +908,28 @@ class CropOverlayView | |||
| ) { | |||
| // Top left | |||
| canvas.drawCircle( | |||
| rect.left, | |||
| rect.left - cornerExtension, | |||
| (rect.top - cornerExtension), | |||
There was a problem hiding this comment.
Added this change to align properly the corners over the edges of the rectangle. Observed this while checking it for smaller radius.
Canato
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are related to #305