Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to github actions #669

Merged
merged 9 commits into from
Dec 30, 2020
Merged

Conversation

ghiculescu
Copy link
Contributor

@ghiculescu ghiculescu commented Dec 9, 2020

This repo is experiencing pretty large CI backlogs at the moment. I'm guessing they are caused by issues @ Travis CI: https://news.ycombinator.com/item?id=25338983

This PR switches the CI over to Github actions, and removes Travis CI.

You can see outputs at https://github.com/ghiculescu/cancancan/actions (or at least I can). I think you'll need to enable something for the checks to show against this PR.

Other changes:

image

@ghiculescu ghiculescu force-pushed the github-actions branch 18 times, most recently from 8a1e071 to 015d061 Compare December 10, 2020 21:12
@ghiculescu ghiculescu marked this pull request as ready for review December 10, 2020 21:13
@ghiculescu ghiculescu force-pushed the github-actions branch 11 times, most recently from 9b8d266 to 62b3352 Compare December 10, 2020 21:55
@ghiculescu
Copy link
Contributor Author

@coorasse this is ready to go, what do you think?

@ghiculescu
Copy link
Contributor Author

image
@coorasse FYI

@coorasse
Copy link
Member

I am very happy of switching to GitHub Actions. I have a personal preference for SemaphoreCI but they lack support for build matrixes and exclude some combinations. 😢
Regarding Truffleruby I'd like to keep it running. @eregon can you help @ghiculescu with the nokogiri issue?

@eregon
Copy link
Contributor

eregon commented Dec 18, 2020

See oracle/truffleruby#62, so just adding this should fix it:

    - run: sudo apt-get -yqq install libxml2-dev libxslt-dev
      if: startsWith(matrix.ruby, 'truffleruby')

.github/workflows/test.yml Outdated Show resolved Hide resolved
@ghiculescu
Copy link
Contributor Author

Thanks for your help @eregon!

@coorasse we are now green on Truffleruby: https://github.com/ghiculescu/cancancan/actions/runs/431036514

@coorasse
Copy link
Member

@ghiculescu could you please re-enable also Travis in this PR? I'd like to run both of them until I have a green build on Github Actions. Afterwards I'll remove the Travis configuration. Thank you! 🙏

@coorasse
Copy link
Member

or maybe is enough to rebase and commit. I enabled Actions now.

@ghiculescu
Copy link
Contributor Author

Hmmm. That doesn't seem to have worked :/

@ghiculescu
Copy link
Contributor Author

@ghiculescu could you please re-enable also Travis in this PR?

Done @coorasse

@coorasse coorasse merged commit 07dc15d into CanCanCommunity:develop Dec 30, 2020
@coorasse
Copy link
Member

Nice! The first build has started 😄 https://github.com/CanCanCommunity/cancancan/actions/runs/452447924

if: ${{ matrix.ruby == 'truffleruby' }}

- name: Install gems
run: bundle install --jobs 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using bundler-cache: true would be much faster, I'll make a PR for that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghiculescu ghiculescu deleted the github-actions branch December 30, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants