-
-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to github actions #669
Conversation
8a1e071
to
015d061
Compare
9b8d266
to
62b3352
Compare
62b3352
to
054190e
Compare
054190e
to
29fc334
Compare
@coorasse this is ready to go, what do you think? |
|
I am very happy of switching to GitHub Actions. I have a personal preference for SemaphoreCI but they lack support for build matrixes and |
See oracle/truffleruby#62, so just adding this should fix it: - run: sudo apt-get -yqq install libxml2-dev libxslt-dev
if: startsWith(matrix.ruby, 'truffleruby') |
Thanks for your help @eregon! @coorasse we are now green on Truffleruby: https://github.com/ghiculescu/cancancan/actions/runs/431036514 |
@ghiculescu could you please re-enable also Travis in this PR? I'd like to run both of them until I have a green build on Github Actions. Afterwards I'll remove the Travis configuration. Thank you! 🙏 |
or maybe is enough to rebase and commit. I enabled Actions now. |
Hmmm. That doesn't seem to have worked :/ |
Done @coorasse |
Nice! The first build has started 😄 https://github.com/CanCanCommunity/cancancan/actions/runs/452447924 |
if: ${{ matrix.ruby == 'truffleruby' }} | ||
|
||
- name: Install gems | ||
run: bundle install --jobs 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using bundler-cache: true
would be much faster, I'll make a PR for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repo is experiencing pretty large CI backlogs at the moment. I'm guessing they are caused by issues @ Travis CI: https://news.ycombinator.com/item?id=25338983
This PR switches the CI over to Github actions, and removes Travis CI.
You can see outputs at https://github.com/ghiculescu/cancancan/actions (or at least I can). I think you'll need to enable something for the checks to show against this PR.
Other changes:
resolve_column_aliases
#657 to run tests against Rails master. I've also added Rails 6.1. To get a green build here, I've included the single code change from Remove unnecessary call toresolve_column_aliases
#657.