-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Unit Tests for CpdBootStrap #30
Create Unit Tests for CpdBootStrap #30
Conversation
…Cambridge-ICCS/ONEFlux into 29-generate-unit-tests-for-cpdbootstrap
"id": "Testcase_1", | ||
"description": "Basic functionality test using US_ARC_sample reference data", | ||
"input": { | ||
"0": "t.csv", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that t.csv
is not in the Testcase_1
folder. Is it because it has name conflict with T.csv
? Maybe Github does not distinguish between lower and upper cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be avoided as some filesystems won't distinguish uppercase from lowercase
For those functions which return an array of structs, we will add an extra optional argument in the MATLAB which flags whether we are testing and do the conversion (either to a struct of arrays or using |
… of test artifacts, and read_file function
I've adopted the JSON encoding approach now. |
tests/unit_tests/test_ustar_cp/test_cpdBootstrapUStarTh4Season20100901.py
Outdated
Show resolved
Hide resolved
tests/unit_tests/test_ustar_cp/test_cpdBootstrapUStarTh4Season20100901.py
Outdated
Show resolved
Hide resolved
tests/unit_tests/test_ustar_cp/test_cpdBootstrapUStarTh4Season20100901.py
Show resolved
Hide resolved
tests/unit_tests/test_ustar_cp/test_cpdBootstrapUStarTh4Season20100901.py
Outdated
Show resolved
Hide resolved
tests/unit_tests/test_ustar_cp/test_cpdFindChangePoint20100901.py
Outdated
Show resolved
Hide resolved
LGTM once those suggestions are resolved by @tztsai |
…20100901.py Co-authored-by: James Emberton <[email protected]>
I've addressed these comments already in previous commits. I've resolved the discussions now. |
Closes #29