Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Unit Tests for CpdBootStrap #30

Merged

Conversation

tztsai
Copy link

@tztsai tztsai commented Sep 11, 2024

Closes #29

"id": "Testcase_1",
"description": "Basic functionality test using US_ARC_sample reference data",
"input": {
"0": "t.csv",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that t.csv is not in the Testcase_1 folder. Is it because it has name conflict with T.csv? Maybe Github does not distinguish between lower and upper cases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be avoided as some filesystems won't distinguish uppercase from lowercase

@tztsai tztsai changed the title Create Unit Tests for CpdBootStrap [WIP] Create Unit Tests for CpdBootStrap Sep 19, 2024
@tztsai tztsai marked this pull request as draft September 19, 2024 13:51
@dorchard
Copy link
Member

For those functions which return an array of structs, we will add an extra optional argument in the MATLAB which flags whether we are testing and do the conversion (either to a struct of arrays or using struct2cell or using JSON).

@tztsai tztsai marked this pull request as ready for review September 25, 2024 15:01
@tztsai tztsai changed the title [WIP] Create Unit Tests for CpdBootStrap Create Unit Tests for CpdBootStrap Sep 25, 2024
@tztsai
Copy link
Author

tztsai commented Sep 25, 2024

For those functions which return an array of structs, we will add an extra optional argument in the MATLAB which flags whether we are testing and do the conversion (either to a struct of arrays or using struct2cell or using JSON).

I've adopted the JSON encoding approach now.

@j-emberton
Copy link
Member

I've tidied up the test I wrote and moved a bunch of stuff into test utility functions in conftest.py

@tztsai Could you review the suggestions I made previously and resolve.

@dorchard , @isaacaka could you guys review please :)

@dorchard
Copy link
Member

LGTM once those suggestions are resolved by @tztsai

@tztsai
Copy link
Author

tztsai commented Oct 17, 2024

I've tidied up the test I wrote and moved a bunch of stuff into test utility functions in conftest.py

@tztsai Could you review the suggestions I made previously and resolve.

@dorchard , @isaacaka could you guys review please :)

I've addressed these comments already in previous commits. I've resolved the discussions now.

@dorchard dorchard merged commit 3aad58b into ustar_cp_refactor_main Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants