Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra unit test on keyword behaviour #25

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

dorchard
Copy link
Member

@dorchard dorchard commented Sep 9, 2024

Adds a unit test on the behaviour of launch.m with partial data tiles missing some of the keywords. This uses the stdout of the MATLAB engine.

@j-emberton
Copy link
Member

Did you base this branch off 'main' rather than test_launch.m?

It's slightly out of sync with my test_launch.m branch which you just reviewed. E.g. setup_folders fixture is now called setup_test_environment.

Otherwise it looks ok

Co-authored-by: Dominic Orchard <[email protected]>
@dorchard
Copy link
Member Author

dorchard commented Sep 9, 2024

Hm. This is based off [refactor_and_test_launch](https://github.com/Cambridge-ICCS/ONEFlux/tree/refactor_and_test_launch). I'm using setup_test_environment, which I think is the most up-to-date name right?

@j-emberton
Copy link
Member

Hm. This is based off [refactor_and_test_launch](https://github.com/Cambridge-ICCS/ONEFlux/tree/refactor_and_test_launch). I'm using setup_test_environment, which I think is the most up-to-date name right?

Sorry I got myself completely confused there, mixing up branch and PR names and all sorts. I think you're all good.

@dorchard dorchard merged commit d3b32b8 into refactor_and_test_launch Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants