Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Melt windows fix #137

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Melt windows fix #137

wants to merge 4 commits into from

Conversation

TomMelt
Copy link
Member

@TomMelt TomMelt commented Jun 19, 2024

fixes #124

This is currently wip. It needs to be tested by end user.

If this fixes the problem I will tidy up the int64 issue and we can merge this PR in.

Tasks:

  • fix cmake windows build issue
  • fix int64 issue properly

@TomMelt TomMelt added the bug Something isn't working label Jun 19, 2024
@TomMelt TomMelt self-assigned this Jun 19, 2024
@jatkinson1000
Copy link
Member

Discussion:

I am debugging issue with windows user. I noticed the latest version of
ifx/ifort builds with a different integer type which leads to error:

```
error #6284: There is no matching specific function for this generic function reference.   [TORCH_TENSOR_FROM_ARRAY]
   in_tensors(1) = torch_tensor_from_array(in_data, tensor_layout, torch_kCPU)
-------------------^
```

This can be removed by forcing the integer type to int64
Integer size for FTorch can now be controlled using parameter `FT_INT`.

Currently, the default is set to `int32` but this could be changed if
required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hackathon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Installation Issue
2 participants