update fork #1
Merged
update fork #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- com.sun.jna.Platform#isAix - com.sun.jna.platform.win32.Ole32#CoCreateGuid(GUID.ByReference pguid) - com.sun.jna.platform.win32.Ole32#CLSIDFromString(WString lpsz, CLSID.ByReference pclsid)
… code The success of attaching to the JVM was checked to late in callback.c. After trying to attach the native thread to the JVM, the JNIEnv pointer is passed to `get_thread_storage`, which uses it to access the JVM. At this point it is assumed, that the JNIEnv pointer is valid and can be used. This is not correct, as the attach can fail and if so the JNIEnv pointer is not valid. The pointer is later validated, but to late, so a SEGFAULT occurs. The result check needs to be moved directly after the attachment code, to be effective. Forward port of c23cde6
Native update
This reverts commit 5bac07c.
Fix bug with recursive IP_ADDR_STRING ByReference
…988) * Zero-check counter and instance lists, add English lookup * Don't zero-check what we're not fetching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.