Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ipython display formatter directly for missing _repr_mimebundle #285

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

morlic
Copy link

@morlic morlic commented Nov 20, 2024

Also fix #232, #284

I am not sure this will be fully backwards compatible, IPython code mentions that _repr_mimebundle_ is there since 6.x and the DisplayFormatter should take care of rendering all registered mimetypes, but still.

My problem was that graphviz Source objects expose only _repr_mimebundle which is not used by the metakernel so I had to wrap that, but this looks like a simple enough fix that worked for me. DisplayFormatter can be configured, perhaps the kernel kwargs should be passed to it, not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

%magic throws
1 participant