Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Clean Architecture + Tests #41

Merged
merged 9 commits into from
Dec 4, 2023
Merged

Email Clean Architecture + Tests #41

merged 9 commits into from
Dec 4, 2023

Conversation

lucieyang1
Copy link
Member

@lucieyang1 lucieyang1 commented Dec 4, 2023

Description

Refactored email usecase to use clean architecture and wrote tests. Tests have 100% coverage of the email use case :)
Refactoring it into ca made it weird to handle errors and give the NOT_FOUND http response entity, so I made some custom exceptions?

image image

Type of change

  • [X]

How Has This Been Tested?

  • EmailTests.java
  • Also manually tested, still works as before!

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@sarinali sarinali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add a screenshot of test coverage please

@lucieyang1 lucieyang1 self-assigned this Dec 4, 2023
@lucieyang1 lucieyang1 merged commit 159a384 into master Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants