Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored add message to session for clean architecture #34

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Refactored add message to session for clean architecture #34

merged 2 commits into from
Nov 30, 2023

Conversation

zjayee
Copy link
Contributor

@zjayee zjayee commented Nov 27, 2023

Description

Refactored add message to session for clean architecture

Fixes # (issue)

Type of change

  • Refactoring

How Has This Been Tested?

Manual testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@zjayee zjayee self-assigned this Nov 27, 2023
sarinali
sarinali approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@sarinali sarinali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works ok for me

@zjayee zjayee merged commit c8fa527 into master Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarinali sarinali sarinali approved these changes

@3milyfz 3milyfz Awaiting requested review from 3milyfz

@lucieyang1 lucieyang1 Awaiting requested review from lucieyang1

Assignees

@zjayee zjayee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zjayee @sarinali