Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploads websocket messages to mongodb #19

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Uploads websocket messages to mongodb #19

merged 3 commits into from
Nov 24, 2023

Conversation

zjayee
Copy link
Contributor

@zjayee zjayee commented Nov 22, 2023

Description

Uploads websocket messages to mongodb when recieved in backend.

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manual tests

@zjayee
Copy link
Contributor Author

zjayee commented Nov 22, 2023

Should be merged after pr#18

@3milyfz
Copy link
Member

3milyfz commented Nov 23, 2023

Good work!

  • The commit messages are clear!
  • I also manually tested your branch locally and messages are being stored as expected
  • ‼️ There is a merge conflict that needs to be resolved

@zjayee
Copy link
Contributor Author

zjayee commented Nov 24, 2023

@3milyfz fixed merge conflict

HashMap<String, String> response = messageInteractor.generateResponse(message);
return gson.toJson(response);
}


private void sendResponseToDatabase(String content, String sessionId, Sender sender){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you place this method in another file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done moved to MessageDataAccess class

@zjayee zjayee merged commit b149faa into master Nov 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants