Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate session code #11

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Generate session code #11

merged 2 commits into from
Nov 6, 2023

Conversation

zjayee
Copy link
Contributor

@zjayee zjayee commented Nov 6, 2023

Added functionality to:

  • Generate unique session codes
  • Return session code and id to user
  • Join session

@zjayee
Added session code generation logic
b0365df
@zjayee
Added join session functionality
7c47308 
Checks if valid session code and returns corresponding session id and code
sarinali
sarinali approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@sarinali sarinali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zjayee zjayee merged commit 021fbbd into master Nov 6, 2023
1 check passed
@zjayee zjayee deleted the generate-session-code branch November 21, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarinali sarinali sarinali approved these changes

@3milyfz 3milyfz Awaiting requested review from 3milyfz

@lucieyang1 lucieyang1 Awaiting requested review from lucieyang1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zjayee @sarinali