Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF upload via backend and PDF fetch via ID #10

Merged
merged 13 commits into from
Nov 7, 2023
Merged

Conversation

sarinali
Copy link
Collaborator

@sarinali sarinali commented Nov 5, 2023

Added 3 endpoints, one for PDF upload to MongoDB, one for PDF upload via local files and one for fetching pdf via ID.

Copy link
Contributor

@zjayee zjayee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments


@Autowired
public DocumentRepository documentRepository;
HttpHeaders headers = new HttpHeaders();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be created inside each method?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case we need to add info to the headers in the future

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for headers you customize with methods, the base is always consistent

src/main/resources/application.properties Outdated Show resolved Hide resolved
@sarinali sarinali merged commit f8349bc into master Nov 7, 2023
1 check failed
@sarinali sarinali deleted the test-workflow branch November 7, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants