Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ActionMessage class for readability and remove if statement that is not needed for UWP #920

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

vb2ae
Copy link
Member

@vb2ae vb2ae commented Nov 4, 2024

Refactored ActionMessage class to improve readability and maintainability:

  • Reformatted constructor, properties, methods, and delegates to include braces {} on new lines.
  • Removed unnecessary comments.
  • Removed unnecessary if statement

Closes #918

Refactored ActionMessage class to improve readability and maintainability:
- Reformatted constructor, properties, methods, and delegates to include braces `{}` on new lines.
- Removed unnecessary comments.
- Added `ElementUnloaded` method to handle element unloading.
- Added `View.ExecuteOnUnload` method to handle actions on element unload.
- Used object initializer syntax for `context` in `UpdateContext`.
@vb2ae vb2ae linked an issue Nov 4, 2024 that may be closed by this pull request
1 task
@vb2ae vb2ae changed the title Refactor ActionMessage class for readability and add methods Refactor ActionMessage class for readability and remove if statement that is not needed for UWP Nov 4, 2024
@vb2ae vb2ae requested a review from KasperSK November 5, 2024 13:13
@KasperSK KasperSK merged commit 62c9d8b into master Nov 5, 2024
4 checks passed
@vb2ae
Copy link
Member Author

vb2ae commented Nov 5, 2024

@KasperSK thanks

@vb2ae vb2ae deleted the 918-fix-code-scanning-alert-futile-conditional branch November 5, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Futile conditional
2 participants