Add readonly modifier to fields
#876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made several fields `readonly` based on Code QL suggestions (Caliburn-Micro#875). This ensures they are only assigned during declaration or inside constructors. Affected files: - src/Caliburn.Micro.Core/SimpleContainer.cs - src/Caliburn.Micro.Platform/Bind.cs - src/Caliburn.Micro.Platform/Platforms/Maui/Windows/MauiPlatformProvider.cs - src/Caliburn.Micro.Platform/Platforms/uap/FrameAdapter.cs - src/Caliburn.Micro.Platform/Platforms/uap/XamlMetadataProvider.cs - src/Caliburn.Micro.Platform/XamlPlatformProvider.cs
Dennis40816
changed the title
readonly modifier to fieldsreadonly modifier to fields
Closed
vb2ae
reviewed
Oct 11, 2023
| @@ -15,7 +15,7 @@ public class SimpleContainer | |||
| private static readonly Type enumerableType = typeof(IEnumerable); | |||
| private static readonly TypeInfo enumerableTypeInfo = enumerableType.GetTypeInfo(); | |||
| private static readonly TypeInfo delegateTypeInfo = delegateType.GetTypeInfo(); | |||
| private Type simpleContainerType = typeof(SimpleContainer); | |||
| private readonly Type simpleContainerType = typeof(SimpleContainer); | |||
vb2ae
reviewed
Oct 11, 2023
| @@ -53,7 +53,7 @@ public static class Bind { | |||
| null, | |||
| ModelWithoutContextChanged); | |||
|
|
|||
| internal static DependencyProperty NoContextProperty = | |||
| internal static readonly DependencyProperty NoContextProperty = | |||
vb2ae
reviewed
Oct 11, 2023
| @@ -17,7 +17,7 @@ namespace Caliburn.Micro | |||
| public class FrameAdapter : INavigationService, IDisposable | |||
| { | |||
| #if WINDOWS_UWP | |||
| private SystemNavigationManager navigationManager; | |||
| private readonly SystemNavigationManager navigationManager; | |||
| #endif | |||
vb2ae
reviewed
Oct 11, 2023
| private Dictionary<string, IXamlType> _xamlTypes = new Dictionary<string, IXamlType>(); | ||
| private Dictionary<string, IXamlMember> _xamlMembers = new Dictionary<string, IXamlMember>(); | ||
| private Dictionary<Type, string> _xamlTypeToStandardName = new Dictionary<Type, string>(); | ||
| private readonly Dictionary<string, IXamlType> _xamlTypes = new Dictionary<string, IXamlType>(); |
vb2ae
reviewed
Oct 11, 2023
| @@ -152,8 +152,8 @@ internal class XamlTypeInfoProvider { | |||
|
|
|||
|
|
|||
| internal class XamlSystemBaseType : IXamlType { | |||
| private string _fullName; | |||
| private Type _underlyingType; | |||
| private readonly string _fullName; | |||
vb2ae
reviewed
Oct 11, 2023
| private string _fullName; | ||
| private Type _underlyingType; | ||
| private readonly string _fullName; | ||
| private readonly Type _underlyingType; | ||
|
|
||
| public XamlSystemBaseType(string fullName, Type underlyingType) { |
vb2ae
reviewed
Oct 11, 2023
| @@ -17,9 +17,9 @@ | |||
| /// </summary> | |||
| public class XamlPlatformProvider : IPlatformProvider { | |||
| #if WINDOWS_UWP | |||
| private CoreDispatcher dispatcher; | |||
| private readonly CoreDispatcher dispatcher; | |||
vb2ae
reviewed
Oct 11, 2023
| #else | ||
| private Dispatcher dispatcher; | ||
| private readonly Dispatcher dispatcher; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made several fields
readonlybased on Code QL suggestions (#875). This ensures they are only assigned during declaration or inside constructors.Affected files: