Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support async methods on the IDeactivateInterface #530

Closed
nigel-sampson opened this issue Jul 8, 2018 · 6 comments
Closed

Support async methods on the IDeactivateInterface #530

nigel-sampson opened this issue Jul 8, 2018 · 6 comments
Milestone

Comments

@nigel-sampson
Copy link
Contributor

No description provided.

@nigel-sampson nigel-sampson added this to the v4.0.0 milestone Jul 8, 2018
nigel-sampson pushed a commit that referenced this issue Jul 8, 2018
@godrose
Copy link

godrose commented Jul 13, 2018

@nigel-sampson Great to have you back!

@nigel-sampson
Copy link
Contributor Author

Cheer, its been a busy few months and definitely not where I'd like to be on this work. The last sticking point with this part will be around the IPlatformProvider and the view close action. It's a bit of a mess.

Once we're done there it'll be aysnc-ing the outer layer of window managers and navigation services.

@godrose
Copy link

godrose commented Jul 14, 2018

@nigel-sampson ping me if you need any assistance.

@nigel-sampson
Copy link
Contributor Author

Any eyes over what'll be required to make WindowManager async would be good. It's before my time and it looks to have a lot of code to handle things being sort of async

nigel-sampson pushed a commit that referenced this issue Oct 2, 2018
@hcd
Copy link

hcd commented Oct 4, 2018

Any idea on the roadmap for 4.0.0 ? We're still using 3.2, but having some issues due to the core methods (OnActivated, OnDeactivated, OnInitialized) are not async/await compatible ...

@nigel-sampson
Copy link
Contributor Author

To be honest it hasn't been going well. I've been struggling with getting repeatable and consistent builds on the dev/4.0.0 branch. I typically see one in five builds succeed randomly which isn't something I'm comfortable with. I suspect the problem is in trying to bend the new project system to the structures previously in place for the project rather than going the other way.

I've been experimenting with building using the new project system from the ground up and finding a lot more success. Hoping to be back to a stable build platform this week when I merge in this private branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants