#528 Remove null checks for nav services that pass values by dictionary

Caliburn-Micro · Apr 24, 2019 · b5ae569 · b5ae569
1 parent 350f94f
commit b5ae569
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/src/Caliburn.Micro.Platform/Platforms/Xamarin.Forms/NavigationHelper.cs b/src/Caliburn.Micro.Platform/Platforms/Xamarin.Forms/NavigationHelper.cs
@@ -22,10 +22,7 @@ public class NavigateHelper<TViewModel>
         /// <returns>Itself</returns>
         public NavigateHelper<TViewModel> WithParam<TValue>(Expression<Func<TViewModel, TValue>> property, TValue value)
         {
-            if (value is ValueType || !ReferenceEquals(null, value))
-            {
-                parameters[property.GetMemberInfo().Name] = value;
-            }
+            parameters[property.GetMemberInfo().Name] = value;
 
             return this;
         }

diff --git a/src/Caliburn.Micro.Platform/Platforms/net46/NavigationHelper.cs b/src/Caliburn.Micro.Platform/Platforms/net46/NavigationHelper.cs
@@ -23,10 +23,7 @@ public class NavigationHelper<TViewModel>
         /// <returns>Itself</returns>
         public NavigationHelper<TViewModel> WithParam<TValue>(Expression<Func<TViewModel, TValue>> property, TValue value)
         {
-            if (value is ValueType || !ReferenceEquals(null, value))
-            {
-                queryString[property.GetMemberInfo().Name] = value;
-            }
+            queryString[property.GetMemberInfo().Name] = value;
 
             return this;
         }