Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't select text on the page #4

Closed
Katzenwerfer opened this issue Jan 14, 2024 · 1 comment
Closed

Can't select text on the page #4

Katzenwerfer opened this issue Jan 14, 2024 · 1 comment

Comments

@Katzenwerfer
Copy link

You cannot select any text on the page, not even text in the player itself.
It seems to me that the root of the problem is how the player is refocused when you click outside of it in the function on lines 198-205.
When commenting out the mentioned function, the problem no longer occurs, but that also breaks refocusing of the space bar into the player.

Calciferz added a commit that referenced this issue Jan 16, 2024
…on. Fixes issue #4: can't select text on the page
Calciferz added a commit that referenced this issue Jan 16, 2024
…on. Fixes issue #4: can't select text on the page
@Calciferz
Copy link
Owner

Calciferz commented Jan 16, 2024

Thank you for the report @Katzenwerfer!
Indeed that was the issue.
Focusing the player was an unpractical feature anyway, so it was removed.

v1.2.0 fixes this: 7111ccf

Calciferz added a commit that referenced this issue Jan 19, 2024
…cription. Fixes issue #4: can't select text on the page
Calciferz added a commit that referenced this issue Jan 19, 2024
…cription. Fixes issue #4: can't select text on the page
Calciferz added a commit that referenced this issue Jan 21, 2024
…cription. Fixes issue #4: can't select text on the page
Calciferz added a commit that referenced this issue Jan 22, 2024
…cription. Fixes issue #4: can't select text on the page
Calciferz added a commit that referenced this issue Jan 22, 2024
…cription. Fixes issue #4: can't select text on the page
Calciferz added a commit that referenced this issue Jan 22, 2024
…cription. Fixes issue #4: can't select text on the page
Calciferz added a commit that referenced this issue Jan 22, 2024
…cription. Fixes issue #4: can't select text on the page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants