Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Add installation instructions for Lithium. #49

Merged
merged 2 commits into from
Jul 20, 2020
Merged

change: Add installation instructions for Lithium. #49

merged 2 commits into from
Jul 20, 2020

Conversation

amnotbananaama
Copy link
Contributor

This is for players who discover this page but maybe aren't familiar with the Fabric ecosystem. Should prevent future issues such as #47. I tried to use wording that was clear without being overly lengthy. If this is satisfactory I'll open a similar PR on the Phosphor page.

(This is my first actual pull request, I hope I followed your guidelines well and this is useful!)

This is for players who discover this page but maybe aren't familiar with the Fabric ecosystem.
@jellysquid3 jellysquid3 added the T-enhancement Type: Enhancement label May 20, 2020
@amnotbananaama
Copy link
Contributor Author

Closing based on Discord discussion

@jellysquid3
Copy link
Member

I was dumb and misunderstood the question on Discord. I think installation instructions are a good idea here.

@jellysquid3 jellysquid3 reopened this Jul 17, 2020
Copy link
Member

@2No2Name 2No2Name left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@2No2Name 2No2Name changed the base branch from 1.16.x/fabric to 1.16.x/dev July 20, 2020 12:26
@2No2Name 2No2Name merged commit a7188df into CaffeineMC:1.16.x/dev Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-enhancement Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants